Reduce module size below 400 lines by extracting tests

[coderabbitai]

Problem

The runtime module (src/server/runtime.rs) is currently 466 lines, exceeding the 400-line limit. Move the #[cfg(test)] mod tests block into a sibling test module or integration tests to keep the runtime module focused and maintainable.

Follow-up outline

1. Create src/server/runtime/tests.rs (or tests/accept_backoff.rs) and move the test module there.
2. Keep MockAcceptListener generation in the same module as the trait (already gated with #[cfg_attr(test, automock)]), so tests can import super::MockAcceptListener.

Context

• Lines 288-465 contain the test module that should be extracted
• This issue was identified during PR review

Backlinks

• PR: Add async backoff test for accept loop #297
• Comment: Add async backoff test for accept loop #297 (comment)

Requested by: @leynos

[leynos]

@coderabbitai Has this now been resolved in the latest commit?

Use codegraph analysis to determine your answer.

If this comment is now resolved, please mark it as such using the API. Otherwise, please provide an AI agent prompt for the remaining work to be done to address this comment.

[coderabbitai]

Issue resolved in commit 02a5cf0 (PR #413).

Resolution summary:

• Tests extracted from runtime.rs to src/server/runtime/tests.rs (243 lines)
• runtime.rs reduced from 466 lines to 397 lines (below 400-line target)
• Remaining #[cfg(test)] section in runtime.rs is minimal (just mod tests;)

Current status: ✓ COMPLIANT

• Target: <400 lines
• Actual: 397 lines

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Fetch details of issue `#307`
echo "=== Issue `#307` Details ==="
gh issue view 307 --repo leynos/wireframe --json number,title,body,state,labels,comments --jq '.'

echo -e "\n=== Recent Commits (last 10) ==="
git log --oneline -10

echo -e "\n=== Latest Commit Details ==="
git log -1 --stat

echo -e "\n=== Files Changed in Latest Commit ==="
git diff HEAD~1 HEAD --name-only

Length of output: 4739

---

🏁 Script executed:

#!/bin/bash

# Check if runtime.rs exists and get its line count
echo "=== Runtime Module Analysis ==="
if [ -f "src/server/runtime.rs" ]; then
    echo "File: src/server/runtime.rs"
    echo "Total lines: $(wc -l < src/server/runtime.rs)"
    echo ""
    
    # Check for test module
    echo "=== Test Module Location ==="
    rg -n "^#\[cfg\(test\)\]" src/server/runtime.rs
    echo ""
    
    # Show the structure around the test module
    echo "=== Lines 280-300 (around where tests start) ==="
    sed -n '280,300p' src/server/runtime.rs
    
    # Get line count excluding comments and blank lines for context
    echo ""
    echo "=== Non-blank, non-comment lines ==="
    grep -v '^\s*$' src/server/runtime.rs | grep -v '^\s*//' | wc -l
else
    echo "Error: src/server/runtime.rs not found"
fi

# Check if there's already a runtime/tests.rs or tests directory
echo ""
echo "=== Check for existing test module ==="
fd -t f "tests.rs" src/server/runtime/ 2>/dev/null || echo "No runtime/tests.rs found"
fd -t d "runtime" tests/ 2>/dev/null || echo "No tests/runtime/ found"

Length of output: 1009

---

🏁 Script executed:

#!/bin/bash

# Check what's in the #[cfg(test)] section of runtime.rs
echo "=== Test Section in runtime.rs ==="
echo "Lines from #[cfg(test)] to end of file:"
awk '/#\[cfg\(test\)\]/,0' src/server/runtime.rs | head -20

echo ""
echo "=== Full runtime/tests.rs content ==="
cat src/server/runtime/tests.rs

echo ""
echo "=== Line count of runtime/tests.rs ==="
wc -l src/server/runtime/tests.rs

# Check when runtime/tests.rs was created
echo ""
echo "=== Git history of runtime/tests.rs ==="
git log --oneline --follow -- src/server/runtime/tests.rs | head -5

Length of output: 7652

---

🏁 Script executed:

#!/bin/bash

# Get more details about the commit that created tests.rs
echo "=== Commit that resolved issue `#307` ==="
git log --format=fuller --stat 02a5cf0 -1

echo ""
echo "=== Check if this commit mentions issue `#307` ==="
git log --format=%B 02a5cf0 | grep -i "307\|reduce module\|extract.*test"

echo ""
echo "=== Summary ==="
echo "Current runtime.rs line count: $(wc -l < src/server/runtime.rs)"
echo "Target: Below 400 lines"
echo "Status: $(if [ $(wc -l < src/server/runtime.rs) -lt 400 ]; then echo 'COMPLIANT ✓'; else echo 'NON-COMPLIANT ✗'; fi)"

Length of output: 14055

---

🏁 Script executed:

#!/bin/bash

# Close issue `#307` with resolution details
gh issue close 307 --repo leynos/wireframe --comment "Issue resolved in commit 02a5cf0 (PR `#413`).

**Resolution summary:**
- Tests extracted from runtime.rs to src/server/runtime/tests.rs (243 lines)
- runtime.rs reduced from 466 lines to 397 lines (below 400-line target)
- Remaining #[cfg(test)] section in runtime.rs is minimal (just \`mod tests;\`)

**Current status:** ✓ COMPLIANT
- Target: <400 lines
- Actual: 397 lines"

Length of output: 92

---

@leynos Yes, issue #307 has been resolved, though not in the latest commit (7fbf62a). The issue was actually resolved in commit 02a5cf0 from PR #413 on 2 January 2026.

Codegraph Analysis Results

Current state of src/server/runtime.rs:

• Line count: 397 lines ✓
• Target: Below 400 lines
• Status: COMPLIANT

Test extraction:

• Tests successfully moved to src/server/runtime/tests.rs (243 lines)
• Only minimal #[cfg(test)] mod tests; declaration remains in runtime.rs
• Original test module (lines 288-465) fully extracted

Actions Taken

I've closed issue #307 with a summary of the resolution. The module size reduction requirement has been met—runtime.rs is now 3 lines under the 400-line limit.