Skip to content

handle_connection method is a stub that immediately closes connections #33

@coderabbitai

Description

@coderabbitai

Problem

The handle_connection method in WireframeApp is currently a stub implementation that yields once and then returns, causing every accepted connection to be torn down immediately after the preamble phase.

Location

Lines 85-96 in src/app.rs

Current Behaviour

The method implementation:

pub async fn handle_connection<S>(&self, _stream: S) 
where S: tokio::io::AsyncRead + tokio::io::AsyncWrite + Send + Unpin + 'static 
{
    tokio::task::yield_now().await;
    // Stream is dropped here, connection closes
}

Impact

This causes confusing behaviour when integration tests start using the API, as connections appear to be accepted but are immediately closed without any frame processing.

Suggested Solutions

Until real frame handling is implemented:

  • Add logging to indicate the stub behaviour
  • Consider gating server code to prevent use in production environments
  • Add clear documentation about the current limitations

Context

This affects the usability of the server API and could lead to confusion during development and testing.

References

Reported by: @leynos

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions