Fix FrameProcessor instantiation in tests#100
Conversation
Reviewer's GuideFix FrameProcessor instantiation by using LengthPrefixedProcessor::default() and switch route handlers from Box closures to Arc-wrapped closures for consistency in tests and examples. Class diagram for handler type change from Box to Arc in route registrationclassDiagram
class RouteHandler {
+call()
}
class BoxedHandler {
+call()
}
class ArcHandler {
+call()
}
RouteHandler <|-- BoxedHandler : Old
RouteHandler <|-- ArcHandler : New
Class diagram for FrameProcessor instantiation changeclassDiagram
class FrameProcessor {
<<interface>>
}
class LengthPrefixedProcessor {
+default()
}
FrameProcessor <|.. LengthPrefixedProcessor
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
d4c9948
into
codex/implement-middleware-chain-using-handlerservice
* Add middleware service chain * Clarify handler consumption * Handle service errors * Fix processor instantiation and handler types (#100)
Summary
LengthPrefixedProcessorinstance instead of referring to the typeArchandlersTesting
make lintmake testhttps://chatgpt.com/codex/tasks/task_e_6855eb853cf083229cb2a874281748fd
Summary by Sourcery
Fix FrameProcessor instantiation and unify route handler wrapper in tests and example
Tests: