-
Notifications
You must be signed in to change notification settings - Fork 0
Fix compile errors and clippy #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ab731b9
Fix compile errors and clippy issues
leynos be70314
Add must_use annotation and fix example
leynos f2c1032
Implement feedback and ensure example compiles
leynos 466f29c
Restore builder chaining
leynos 771b951
Clarify runnable example
leynos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -28,42 +28,18 @@ impl<F> WireframeServer<F> | |||||||||
| where | ||||||||||
| F: Fn() -> WireframeApp + Send + Sync + Clone + 'static, | ||||||||||
| { | ||||||||||
| /// Constructs a new `WireframeServer` using the provided application factory closure. | ||||||||||
| /// | ||||||||||
| /// The server is initialised with a default worker count equal to the number of CPU cores. | ||||||||||
| /// | ||||||||||
| /// ```no_run | ||||||||||
| /// use wireframe::{app::WireframeApp, server::WireframeServer}; | ||||||||||
| /// | ||||||||||
| /// let factory = || WireframeApp::new().unwrap(); | ||||||||||
| /// let server = WireframeServer::new(factory); | ||||||||||
| /// ``` | ||||||||||
| workers: num_cpus::get().max(1), | ||||||||||
| /// Construct a new server using the supplied application factory. | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: Include default worker count behavior in documentation Please note in the documentation that the default worker count is determined by the number of CPU cores.
Suggested change
|
||||||||||
| #[must_use] | ||||||||||
| pub fn new(factory: F) -> Self { | ||||||||||
| Self { | ||||||||||
| factory, | ||||||||||
| listener: None, | ||||||||||
| workers: num_cpus::get(), | ||||||||||
| } | ||||||||||
| } | ||||||||||
|
|
||||||||||
| /// Set the number of worker tasks to spawn for the server. | ||||||||||
| /// | ||||||||||
| /// #[tokio::main] | ||||||||||
| /// async fn main() -> std::io::Result<()> { | ||||||||||
| /// let factory = || WireframeApp::new().unwrap(); | ||||||||||
| /// WireframeServer::new(factory) | ||||||||||
| /// .workers(4) | ||||||||||
| /// .bind("127.0.0.1:0".parse().unwrap())? | ||||||||||
| /// .run() | ||||||||||
| /// .await | ||||||||||
| /// } | ||||||||||
| /// A new `WireframeServer` instance with the updated worker count. | ||||||||||
| /// | ||||||||||
| /// # Examples | ||||||||||
| /// | ||||||||||
| /// ```ignore | ||||||||||
| /// let server = WireframeServer::new(factory).workers(4); | ||||||||||
| /// Sets the number of worker tasks for the server, ensuring at least one worker. | ||||||||||
| /// | ||||||||||
| /// # Examples | ||||||||||
| /// | ||||||||||
| /// ```ignore | ||||||||||
| /// let server = WireframeServer::new(factory).workers(4); | ||||||||||
| /// ``` | ||||||||||
| /// Set the number of worker tasks to spawn. | ||||||||||
| #[must_use] | ||||||||||
| pub fn workers(mut self, count: usize) -> Self { | ||||||||||
| self.workers = count.max(1); | ||||||||||
| self | ||||||||||
|
|
||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.