Fix Ping Pong example generics#117
Conversation
Reviewer's GuideExample updated to correctly apply generics to the Transform trait for both PongMiddleware and LoggingService and to import the Packet trait, ensuring middleware works with typed HandlerService and HandlerService. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
af57d52
into
p8ondr-codex/expand-examples-with-routing-and-middleware-demo
* Add netcat usage example for echo * Fix HandlerService generics in ping_pong example (#117)
Summary
Packetimports and specifyHandlerServicegenericTransformforLoggingTesting
make lintmake testhttps://chatgpt.com/codex/tasks/task_e_68589bcc015083228d43e0af7c0f5a44
Summary by Sourcery
Fix generics in the ping_pong example by adding the missing Packet import and updating the Transform implementations for PongMiddleware and Logging to use the correct generic parameters.
Bug Fixes: