Refactor extractor tests with shared fixtures#188
Conversation
Reviewer's GuideThis PR refactors the extractor and app_data tests by introducing shared File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning Rate limit exceeded@leynos has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 37 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (6)
Summary by CodeRabbit
WalkthroughThe test modules in Changes
Sequence Diagram(s)sequenceDiagram
participant TestRunner
participant rstest
participant FixtureRequest
participant FixturePayload
participant TestFunction
TestRunner->>rstest: Start test with #[rstest]
rstest->>FixtureRequest: Create MessageRequest fixture
rstest->>FixturePayload: Create Payload fixture
rstest->>TestFunction: Inject fixtures as parameters
TestFunction->>TestFunction: Execute test logic with fixtures
TestFunction-->>TestRunner: Return test result
Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
tests/app_data.rs(2 hunks)tests/extractor.rs(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
`**/*.rs`: Comment why, not what. Explain assumptions, edge cases, trade-offs, o...
**/*.rs: Comment why, not what. Explain assumptions, edge cases, trade-offs, or complexity. Don't echo the obvious.
Comments must use en-GB-oxendict spelling and grammar.
Function documentation must include clear examples.
Every module must begin with a module level (//!) comment explaining the module's purpose and utility.
Document public APIs using Rustdoc comments (///) so documentation can be generated with cargo doc.
Place function attributes after doc comments.
Do not usereturnin single-line functions.
Use predicate functions for conditional criteria with more than two branches.
Lints must not be silenced except as a last resort.
Lint rule suppressions must be tightly scoped and include a clear reason.
Preferexpectoverallow.
Prefer.expect()over.unwrap().
Clippy warnings MUST be disallowed.
Fix any warnings emitted during tests in the code itself rather than silencing them.
Where a function is too long, extract meaningfully named helper functions adhering to separation of concerns and CQRS.
Where a function has too many parameters, group related parameters in meaningfully named structs.
Where a function is returning a large error consider usingArcto reduce the amount of data returned.
Write unit and behavioural tests for new functionality. Run both before and after making any change.
Prefer immutable data and avoid unnecessarymutbindings.
Handle errors with theResulttype instead of panicking where feasible.
Avoidunsafecode unless absolutely necessary and document any usage clearly.
📄 Source: CodeRabbit Inference Engine (AGENTS.md)
List of files the instruction was applied to:
tests/app_data.rstests/extractor.rs
`**/*.rs`: * Seek to keep the cyclomatic complexity of functions no more than 12...
**/*.rs: * Seek to keep the cyclomatic complexity of functions no more than 12.
Adhere to single responsibility and CQRS
Place function attributes after doc comments.
Do not use
returnin single-line functions.Move conditionals with >2 branches into a predicate function.
Avoid
unsafeunless absolutely necessary.Every module must begin with a
//!doc comment that explains the module's purpose and utility.Comments must use en-GB-oxendict spelling and grammar.
Lints must not be silenced except as a last resort.
#[allow]is forbidden.- Only narrowly scoped
#[expect(lint, reason = "...")]is allowed.- No lint groups, no blanket or file-wide suppression.
- Include
FIXME:with link if a fix is expected.Use
rstestfixtures for shared setup and to avoid repetition between tests.Replace duplicated tests with
#[rstest(...)]parameterised cases.Prefer
mockallfor mocks/stubs.Prefer
.expect()over.unwrap()Ensure that any API or behavioural changes are reflected in the documentation in
docs/Ensure that any completed roadmap steps are recorded in the appropriate roadmap in
docs/
⚙️ Source: CodeRabbit Configuration File
List of files the instruction was applied to:
tests/app_data.rstests/extractor.rs
🧬 Code Graph Analysis (2)
tests/app_data.rs (2)
tests/extractor.rs (2)
request(15-15)empty_payload(19-19)src/extractor.rs (4)
from_message_request(184-187)from_message_request(265-271)from_message_request(328-335)from_message_request(372-379)
tests/extractor.rs (2)
tests/app_data.rs (2)
request(16-16)empty_payload(20-20)src/extractor.rs (7)
from_message_request(184-187)from_message_request(265-271)from_message_request(328-335)from_message_request(372-379)remaining(165-165)peer_addr(362-362)state(54-62)
⏰ Context from checks skipped due to timeout of 240000ms (2)
- GitHub Check: build-test
- GitHub Check: Analyze (actions)
🔇 Additional comments (6)
tests/app_data.rs (2)
22-30: Well-structured fixture usage.The test correctly uses the fixtures as parameters, maintaining the original test logic whilst benefiting from shared setup.
32-41: Consistent fixture usage across tests.The test properly leverages the fixtures, ensuring consistency with the other test whilst preserving the original assertions.
tests/extractor.rs (4)
29-38: Excellent fixture integration.The test effectively uses the fixture parameter whilst maintaining the original test logic and comprehensive documentation.
40-50: Proper fixture usage with mutable parameters.The test correctly uses both fixtures as parameters, including the mutable modifications needed for the test scenario.
57-65: Consistent fixture application.The test properly leverages the fixtures whilst preserving the original shared state testing logic.
72-85: Well-maintained error testing with fixtures.The test correctly uses fixtures for error scenario testing, maintaining the original error handling verification.
1 participant
Summary
rstestfixturestests/app_data.rsTesting
make fmtmake lintmake testhttps://chatgpt.com/codex/tasks/task_e_686a839b10d0832282f05d30c343e15c
Summary by Sourcery
Tests: