Skip to content

Add queue_frames edge case tests #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leynos merged 3 commits into from
Jul 8, 2025
Merged

Add queue_frames edge case tests #197

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9cf1a47
Add queue_frames edge case tests
leynos Jul 7, 2025
25404aa
Remove redundant queue frame tests
leynos Jul 8, 2025
36a01ae
Merge branch 'main' into codex/add-tests-for-empty-and-single-element…
leynos Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions tests/connection_actor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,25 @@ async fn queue_frames(
highs.into_iter().chain(lows.into_iter()).collect()
}

// Ensure the helper correctly handles edge cases without queued frames.
#[rstest]
#[case(vec![Priority::High, Priority::High, Priority::High, Priority::Low, Priority::Low])]
#[case(vec![Priority::Low, Priority::Low, Priority::High, Priority::High, Priority::High])]
#[tokio::test]
async fn queue_frames_empty_input(queues: (PushQueues<u8>, wireframe::push::PushHandle<u8>)) {
let (_, handle) = queues;
let priorities: &[Priority] = &[];
let result = queue_frames(priorities, &handle, 0).await;
assert!(result.is_empty(), "Expected empty output for empty input");
}
Comment on lines +122 to +130
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider removing this test in favour of the parameterised case.

This standalone test duplicates coverage already provided by the Vec::new() case in the parameterised test below. The parameterised test is more comprehensive as it tests the full actor behaviour rather than just the helper function.

Following the coding guideline to "replace duplicated tests with #[rstest(...)] parameterised cases", this standalone test should be removed.

🤖 Prompt for AI Agents 
In tests/connection_actor.rs around lines 122 to 130, the standalone test
queue_frames_empty_input duplicates coverage already provided by the
parameterised test with Vec::new(). Remove this standalone test to avoid
redundancy and follow the guideline of replacing duplicated tests with
parameterised cases that cover the full actor behaviour.


#[rstest]
#[case(Vec::new())]
#[case(vec![Priority::High])]
#[case(vec![Priority::Low])]
#[case(vec![Priority::High, Priority::Low])]
#[case(vec![Priority::High; 3])]
#[case(vec![Priority::Low; 3])]
#[case(vec![Priority::High, Priority::High, Priority::High, Priority::Low, Priority::Low])]
#[case(vec![Priority::Low, Priority::Low, Priority::High, Priority::High, Priority::High])]
#[case(vec![
Priority::High,
Priority::Low,
Expand Down