-
Notifications
You must be signed in to change notification settings - Fork 0
Make exponential backoff parameters configurable in accept_loop #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0e50e89
Make exponential backoff parameters configurable in accept_loop
devin-ai-integration[bot] 14cfbc3
Address CodeRabbit feedback: improve documentation and validation
devin-ai-integration[bot] b7c12b5
Complete documentation examples for backoff configuration methods
devin-ai-integration[bot] ee17018
Address CodeRabbit feedback: make accept_backoff validation explicit
devin-ai-integration[bot] 0319569
Add exponential backoff behavior test
devin-ai-integration[bot] 914da84
Document accept backoff configuration (#292)
leynos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Server configuration | ||
|
|
||
| `WireframeServer` provides a builder API for adjusting runtime behaviour. This | ||
| guide focuses on tuning the exponential backoff used when accepting connections | ||
| fails. | ||
|
|
||
| ## Accept loop backoff | ||
|
|
||
| The accept loop retries failed `accept()` calls using exponential backoff. | ||
| `accept_backoff(initial_delay, max_delay)` sets both bounds in one call. These | ||
| values are stored in `BackoffConfig`: | ||
|
|
||
| - `initial_delay` – starting delay for the first retry, clamped to at least 1 | ||
| millisecond. | ||
| - `max_delay` – maximum delay for retries, never less than `initial_delay`. | ||
|
|
||
| ### Behaviour | ||
|
|
||
| - If `initial_delay` exceeds `max_delay`, the values are swapped. | ||
| - `max_delay` is raised to match `initial_delay` when required. | ||
|
|
||
| ### Example | ||
|
|
||
| ```rust | ||
| use std::time::Duration; | ||
|
|
||
| use wireframe::{app::WireframeApp, server::WireframeServer}; | ||
|
|
||
| let server = WireframeServer::new(|| WireframeApp::default()) | ||
| .accept_backoff(Duration::from_millis(5), Duration::from_millis(500)); | ||
| ``` | ||
|
|
||
| `accept_initial_delay` and `accept_max_delay` allow adjusting each parameter | ||
| individually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.