Rename BackoffConfig.normalised to normalized (US spelling)#446
Conversation
Renamed `BackoffConfig::normalised` method to `normalized` to align with American English spelling in the public API. Updated all references and documentation accordingly, including changelog, doc comments, and source code. This is a breaking change for downstream consumers who must update their code to use the new method name. Co-authored-by: devboxerhub[bot] <devboxerhub[bot]@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRenames the Backoff configuration API method from Class diagram for BackoffConfig method rename to normalizedclassDiagram
class BackoffConfig_Before {
Duration initial_delay
Duration max_delay
BackoffConfig normalised()
}
class BackoffConfig_After {
Duration initial_delay
Duration max_delay
BackoffConfig normalized()
}
BackoffConfig_Before <.. BackoffConfig_After
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary by CodeRabbit
WalkthroughThis PR standardises the spelling of the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/server/configuration.md`:
- Around line 58-59: Change the narrative text “normalises” to the Oxford “-ize”
form “normalizes” in the sentence that references the builder, but do not alter
the API/code identifier BackoffConfig::normalized (keep its spelling and
formatting intact); update the plain-text word only so the sentence reads:
"builder normalizes the supplied configuration via `BackoffConfig::normalized`,
so out-of-range values are adjusted rather than preserved."
In `@src/server/config/mod.rs`:
- Around line 142-146: The doc comment uses British variant "Normalisation" but
project requires en-GB-oxendict "-ize" spellings; update the doc text around
BackoffConfig::normalized (and any mentions like cfg.normalized()) to use
"Normalization" (and adjust any other occurrences of "normalisation" ->
"normalization") so the docs match the coding guideline.
Summary
Changes
Core changes
BackoffConfig::normalised()withBackoffConfig::normalized().src/server/runtime.rs, usebackoff.normalized()when preparing the backoff configuration.src/server/config/mod.rs, document and referencecfg.normalized()instead ofcfg.normalised().normalized.Documentation changes
BackoffConfig::normalized.normalisedupdated tonormalized.src/server/runtime/backoff.rsupdated accordingly.Tests / Examples changes
normalised()tonormalized().Migration Guide
cfg.normalised()tocfg.normalized()backoff.normalised()tobackoff.normalized()Test plan
normalised()in code or docs.normalized()backoff configuration.◳ Generated by DevBoxer ◰
ℹ️ Tag @devboxerhub to ask questions and address PR feedback
📎 Task: https://www.devboxer.com/task/1bd3b44a-656f-416a-a9fd-f0b1c4073512
📝 Closes #441
Summary by Sourcery
Rename the backoff configuration normalisation method to use American English spelling and update all references across code, configuration, and docs.
Enhancements:
BackoffConfig::normalisedtoBackoffConfig::normalizedand update runtime usage and server configuration to match.Documentation:
BackoffConfig::normalizedand note the breaking API change.Chores: