-
Notifications
You must be signed in to change notification settings - Fork 0
Define derived defaults for connection memory budgets #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2b29008
feat(memory_budgets): derive default memory budgets from buffer_capacity
leynos 7187ac7
refactor(memory budgets): extract budget derivation helper and stream…
leynos db2517d
test(fixtures): add server join timeout to prevent indefinite hangs
leynos 8797b78
test(memory_budgets): enhance tests for memory budget calculations an…
leynos 9068c97
docs(tests): add comment explaining magic multiplier in fragmentation…
leynos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
727 changes: 727 additions & 0 deletions
727
docs/execplans/8-3-5-Define derived defaults based on buffer_capacity.md
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| @derived_memory_budgets | ||
| Feature: Derived memory budget defaults from buffer capacity | ||
| When memory budgets are not set explicitly, sensible defaults are derived | ||
| from the codec buffer capacity, enabling all three tiers of protection. | ||
|
|
||
| Scenario: Derived budgets enforce per-connection limit | ||
| Given a derived-budget app with buffer capacity 512 | ||
| When derived-budget first frames for keys 1 to 95 each with body size 400 arrive | ||
| Then the derived-budget connection terminates with an error | ||
|
|
||
| Scenario: Derived budgets allow frames within limits | ||
| Given a derived-budget app with buffer capacity 512 | ||
| When a derived-budget first frame for key 1 with body "bb" arrives | ||
| And a derived-budget final continuation for key 1 sequence 1 with body "cc" arrives | ||
| Then derived-budget payload "bbcc" is eventually received | ||
| And no derived-budget connection error is recorded | ||
|
|
||
| Scenario: Explicit budgets override derived defaults | ||
| Given a derived-budget app with buffer capacity 512 and explicit budgets 2048/8/8 | ||
| When derived-budget first frames for keys 1 to 11 each with body "aaaaaaaa" arrive | ||
| Then the derived-budget connection terminates with an error |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.