Skip to content

Fix doctest examples#52

Merged
leynos merged 2 commits intomainfrom
codex/fix-doctests-to-pass-build-and-tests
Jun 15, 2025
Merged

Fix doctest examples#52
leynos merged 2 commits intomainfrom
codex/fix-doctests-to-pass-build-and-tests

Conversation

@leynos
Copy link
Copy Markdown
Owner

@leynos leynos commented Jun 15, 2025

Summary

  • fix doctest for Message::from_bytes
  • adjust read_preamble example to avoid EOF
  • disable compilation of process_stream example since it's private

Testing

  • cargo clippy -- -D warnings
  • RUSTFLAGS="-D warnings" cargo test --quiet

https://chatgpt.com/codex/tasks/task_e_684eb08917048322a22db65ace067616

Summary by Sourcery

Fix and update doctest examples in preamble, server, and message modules to ensure they compile and avoid EOF.

Documentation:

  • Update read_preamble example to use u64 and big-endian fixed-int encoding to prevent EOF
  • Correct Message example import path to wireframe::message::Message
  • Mark process_stream example as ignored and comment out its invocation since the function is private

Summary by CodeRabbit

  • Documentation
    • Updated example code in documentation for improved clarity and accuracy, including import paths, usage examples, and code block markers. No changes to functionality or public interfaces.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Jun 15, 2025

Reviewer's Guide

This PR refines various doctest examples: it enhances the read_preamble example to prevent EOF by using fixed, big-endian encoding, disables the private process_stream example in server docs, and corrects the Message trait import path in the message doctest.

Updated class diagram for MyPreamble struct in doctest

classDiagram
  class MyPreamble {
    +u64 value
  }
Loading

File-Level Changes

Change Details Files
Enhanced read_preamble example to avoid EOF issues
  • Changed MyPreamble type from u8 to u64
  • Added .with_big_endian() and .with_fixed_int_encoding() to bincode config
  • Reformatted encode_to_vec call to a multiline block for readability
src/preamble.rs
Disabled private process_stream example in server docs
  • Switched code block from no_run to ignore
  • Commented out the process_stream invocation to prevent compilation
src/server.rs
Fixed import path in Message doctest
  • Updated use your_crate::Message to use wireframe::message::Message
src/message.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 15, 2025

Walkthrough

This update revises documentation examples in three source files. Changes include updating import paths, adjusting example struct types and encoding configurations, and modifying example code usage in doc comments. No functional or logic changes were made to any code; only documentation and example code were affected.

Changes

File(s) Change Summary
src/message.rs Updated import path in the Message trait documentation example from your_crate::Message to wireframe::message::Message.
src/preamble.rs Modified example struct inner type from u8 to u64 and updated encoding configuration to use big-endian and fixed integer encoding in the read_preamble doc example.
src/server.rs Removed imports and commented out invocation of process_stream in the documentation example to disable compilation/testing of the example.

Possibly related PRs

  • Fix doctest compilation #51: Updates documentation examples in the same files, focusing on import paths and example code formatting without altering functional code.

Poem

In the docs, the rabbits hop,
Examples pruned from top to top.
Imports set and types aligned,
Encoding clear, all redefined.
No logic changed, just code that shows—
The way a careful rabbit goes!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e1a4efc and e478f30.

📒 Files selected for processing (1)
  • src/server.rs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/server.rs
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build-test
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
6 Quality Gates Passed

See analysis details in CodeScene

Absence of Expected Change Pattern

  • wireframe/src/server.rs is usually changed with: wireframe/src/extractor.rs, wireframe/src/middleware.rs

Quality Gate Profile: Pay Down Tech Debt
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leynos - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/server.rs (1)

369-377: Minor doc-test nit: consider no_run instead of ignore

Marking the block as ignore entirely skips compilation, so future signature changes to process_stream won’t be caught.
If you still want to prevent execution while keeping the compile-check, switching to no_run is enough:

-```ignore
+```no_run
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4382715 and e1a4efc.

📒 Files selected for processing (3)
  • src/message.rs (1 hunks)
  • src/preamble.rs (1 hunks)
  • src/server.rs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build-test
🔇 Additional comments (2)
src/preamble.rs (1)

80-91: Doc-example update looks good

The snippet now uses an explicit big-endian + fixed-int config and a wider u64, matching the decoder settings below. Nice catch.

src/message.rs (1)

32-32: Corrected import path

Switching the example to wireframe::message::Message removes the former placeholder crate name and should compile inside downstream projects.

Copy link
Copy Markdown

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
6 Quality Gates Passed

See analysis details in CodeScene

Absence of Expected Change Pattern

  • wireframe/src/server.rs is usually changed with: wireframe/src/extractor.rs, wireframe/src/middleware.rs

Quality Gate Profile: Pay Down Tech Debt
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

@leynos leynos merged commit 7e47df8 into main Jun 15, 2025
3 checks passed
@leynos leynos deleted the codex/fix-doctests-to-pass-build-and-tests branch June 15, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant