-
Notifications
You must be signed in to change notification settings - Fork 0
Implement connection lifecycle hooks #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| use std::sync::{ | ||
| Arc, | ||
| atomic::{AtomicUsize, Ordering}, | ||
| }; | ||
|
|
||
| use tokio::io::duplex; | ||
| use wireframe::app::WireframeApp; | ||
|
|
||
| #[tokio::test] | ||
| async fn setup_and_teardown_callbacks_run() { | ||
| let setup_count = Arc::new(AtomicUsize::new(0)); | ||
| let teardown_count = Arc::new(AtomicUsize::new(0)); | ||
|
|
||
| let setup_clone = setup_count.clone(); | ||
| let teardown_clone = teardown_count.clone(); | ||
|
|
||
| let app = WireframeApp::new() | ||
| .unwrap() | ||
| .on_connection_setup(move || { | ||
| let setup_clone = setup_clone.clone(); | ||
| async move { | ||
| setup_clone.fetch_add(1, Ordering::SeqCst); | ||
| 42u32 | ||
| } | ||
| }) | ||
| .unwrap() | ||
| .on_connection_teardown(move |state| { | ||
| let teardown_clone = teardown_clone.clone(); | ||
| async move { | ||
| assert_eq!(state, 42u32); | ||
| teardown_clone.fetch_add(1, Ordering::SeqCst); | ||
| } | ||
| }) | ||
| .unwrap(); | ||
|
|
||
| let (_client, server) = duplex(64); | ||
| app.handle_connection(server).await; | ||
|
|
||
| assert_eq!(setup_count.load(Ordering::SeqCst), 1); | ||
| assert_eq!(teardown_count.load(Ordering::SeqCst), 1); | ||
| } | ||
| #[tokio::test] | ||
| async fn setup_without_teardown_runs() { | ||
| let setup_count = Arc::new(AtomicUsize::new(0)); | ||
| let setup_clone = setup_count.clone(); | ||
|
|
||
| let app = WireframeApp::new() | ||
| .unwrap() | ||
| .on_connection_setup(move || { | ||
| let setup_clone = setup_clone.clone(); | ||
| async move { | ||
| setup_clone.fetch_add(1, Ordering::SeqCst); | ||
| } | ||
| }) | ||
| .unwrap(); | ||
|
|
||
| let (_client, server) = duplex(64); | ||
| app.handle_connection(server).await; | ||
|
|
||
| assert_eq!(setup_count.load(Ordering::SeqCst), 1); | ||
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn teardown_without_setup_does_not_run() { | ||
| let teardown_count = Arc::new(AtomicUsize::new(0)); | ||
| let teardown_clone = teardown_count.clone(); | ||
|
|
||
| let app = WireframeApp::new() | ||
| .unwrap() | ||
| .on_connection_teardown(move |_| { | ||
| let teardown_clone = teardown_clone.clone(); | ||
| async move { | ||
| teardown_clone.fetch_add(1, Ordering::SeqCst); | ||
| } | ||
| }) | ||
| .unwrap(); | ||
|
|
||
| let (_client, server) = duplex(64); | ||
| app.handle_connection(server).await; | ||
|
|
||
| assert_eq!(teardown_count.load(Ordering::SeqCst), 0); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (review_instructions): Function attribute is placed before the doc comment; attributes must come after the doc comment.
Please move the #[allow(clippy::type_complexity)] attribute below the doc comment for the struct, as per the style guide.
Review instructions:
Path patterns:
**/*.rsInstructions:
Ensure that function attributes are placed AFTER the function doc comment