Fix processor usage in routes test

[leynos]

Summary

• implement Clone for LengthPrefixedProcessor
• create a processor fixture for tests
• reuse the same processor instance in the routes test

Testing

• make fmt
• make lint
• make test

---

https://chatgpt.com/codex/tasks/task_e_68558c3a2f608322bcf8739c022f97b1

Summary by Sourcery

Derive Clone for LengthPrefixedProcessor, add a reusable processor fixture, and refactor the routes test to consistently use the same processor instance for framing.

Bug Fixes:

• Fix routes test to use a cloned processor instance for both encoding and decoding frames.

Enhancements:

• Derive Clone on LengthPrefixedProcessor.

Tests:

• Introduce a rstest fixture for LengthPrefixedProcessor.
• Update routes test to inject and reuse the processor fixture instead of creating new instances.

Summary by CodeRabbit

• Tests
  • Improved test structure by introducing parameterised tests for message handling and echo response.
  • Added a reusable test fixture for the frame processor to streamline test setup.
• Chores
  • Enhanced internal consistency by allowing the frame processor to be cloned where needed.

[sourcery-ai]

Reviewer's Guide

This PR enables reuse of a single LengthPrefixedProcessor in tests by deriving Clone, adding a rstest fixture, and refactoring the routes test to leverage the processor instance for framing operations.

Class diagram for LengthPrefixedProcessor with Clone implementation

classDiagram
    class LengthPrefixedProcessor {
        +LengthFormat format
        +clone()
    }
    LengthPrefixedProcessor --|> Clone

Loading

File-Level Changes

Change	Details	Files
Enable cloning of the frame processor	Derive Clone on the LengthPrefixedProcessor struct	src/frame.rs
Introduce a reusable processor fixture for tests	Define a processor() fixture with #[fixture] and default constructor	tests/util.rs
Refactor routes test to use the processor fixture	Import processor fixture alongside run_app_with_frame Add processor parameter to the async test function Use processor.clone() for frame_processor setup Replace static encode/decode calls with processor instance methods	tests/routes.rs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The LengthPrefixedProcessor struct now derives the Clone trait. Tests have been refactored to inject a processor instance using the rstest fixture, allowing parameterised testing. The test utility module introduces a fixture for creating processor instances, and test code consistently uses the injected processor.

Changes

File(s)	Change Summary
src/frame.rs	Added #[derive(Clone)] to LengthPrefixedProcessor struct.
tests/routes.rs	Refactored test to accept LengthPrefixedProcessor as a parameter using rstest fixture.
tests/util.rs	Added processor fixture returning a default LengthPrefixedProcessor. Updated imports.

Sequence Diagram(s)

sequenceDiagram
    participant TestRunner
    participant Fixture as processor()
    participant Test as handler_receives_message_and_echoes_response
    participant App as WireframeApp

    TestRunner->>Fixture: Create LengthPrefixedProcessor
    Fixture-->>Test: Provide processor instance
    Test->>App: Pass processor to WireframeApp
    Test->>App: Encode and decode frames using processor
    App-->>Test: Echoes response

Loading

Possibly related PRs

• Fix processor usage in routes test #94: Refactors the same test to use an instance of LengthPrefixedProcessor, directly overlapping in test code changes.
• Add configurable length prefixed framing #87: Redesigns LengthPrefixedProcessor with new fields and methods, upon which this PR builds by adding Clone and updating tests.
• Make frame processors stateless #70: Introduces LengthPrefixedProcessor and makes the processor trait stateless, foundational to the current changes.

Poem

A processor now learns to clone,
In tests its instance stands alone.
Fixtures hop in, with rstest cheer,
Echoing frames both far and near.
With code refactored, neat and bright,
The rabbit dances through the night! 🐇✨

✨ Finishing Touches

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in Comment
• Commit Unit Tests in branch codex/fix-lint-errors-in-tests/routes.rs

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sourcery-ai]

Hey @leynos - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[leynos]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.