Use Yetus container from lfedge/eve-yetus #5397
Conversation
Start to use our Yetus container, which has dependencies already installed (e.g. ZFS lib, etc). Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
|
@rucoder , we had a discuss before about create a lf-edge/eve-yetus project and one of the points raised was that this would be a new project to maintain, build, etc, my plan is to provide the sources here in eve repo and create a GH action to build the eve-yetus image on demand (since this is something we won't upgrade very often).... I don't mind to do that in this PR, but this will take time, or we can merge this one and leave a bit more just with the image.... |
That makes sense. But please add a disclaimer then. |
| @echo Running yetus | ||
| mkdir -p yetus-output | ||
| docker run --rm -v $(CURDIR):/src:delegated,z ghcr.io/apache/yetus:0.15.1 \ | ||
| docker run --rm -v $(CURDIR):/src:delegated,z docker.io/lfedge/eve-yetus:latest \ |
There was a problem hiding this comment.
@rene to be honest using 'latest' is not a good idea. we will not be able to track changes besides if we ever intruduce incomaptibility e.g. in linter settings "old" branches may stat failing eventually
There was a problem hiding this comment.
that's the only TAG we have available.... I will handle in the other PR....
There was a problem hiding this comment.
@rucoder , see my other PR. I don't want to use something like 0.15.1 because we are customizing the image, so I'm open for a good version scheme suggestion. Otherwise, I think it's ok to keep latest on master, we can create other TAGs for stable branches in the future...
There was a problem hiding this comment.
@rene why don't we put a tag eve-yetus-0.15.1 - so we know it is eve and it is based on 0.15.1, now we can troubleshoot future yetus issue if e.g. one PR runs yetus successfully and then you push new version and another PR failed on yetus
There was a problem hiding this comment.
@rene why don't we put a tag eve-yetus-0.15.1 - so we know it is eve and it is based on 0.15.1, now we can troubleshoot future yetus issue if e.g. one PR runs yetus successfully and then you push new version and another PR failed on yetus
@rene or better eve-yetus-0.15.1-1 where -1 is internal revision e.g. you updated golint
There was a problem hiding this comment.
ok, let me rework a bit and I will update the PR....
2 participants
Description
Start to use our Yetus container, which has dependencies already installed (e.g. ZFS lib, etc).
How to test and validate this PR
Run the following commands and check if everything works:
make yetusmake mini-yetusChangelog notes
No user-facing changes.
PR Backports
Checklist
check them.