Use space to separate date and time portions of Time literals #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How did this ever work then? |
Contributor
Author
|
From what I can tell, we've been using the |
|
👍 |
Contributor
Author
|
Changed it to specify the format rather than |
|
even better |
Collaborator
|
@cbandy mind rebasing this to master so we can retest since it's been so long? That should also fix the go 1.4 errors. |
PostgreSQL accepts this format as input to more temporal types.
Contributor
Author
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the error in (and motivation for) #391:
I couldn't find a spec that called for space rather than
T, but every version of Postgres I tested behaves this way.I've included a test for the negative case in case Postgres changes and we want to revert this.