Skip to content

Conversation

@jwpeterson
Copy link
Member

DirichletBoundaries was previously responsible for deleting, but not
allocating, the pointers that it held, which made understanding the
ownership semantics a bit challenging and caused us to have to define
a non-trivial destructor (in dof_map_constraints.C).

DirichletBoundaries was previously responsible for deleting, but not
allocating, the pointers that it held, which made understanding the
ownership semantics a bit challenging and caused us to have to define
a non-trivial destructor (in dof_map_constraints.C).
@moosebuild
Copy link

Job Coverage on 5af4570 wanted to post the following:

Coverage

babff9 #3270 5af457
Total Total +/- New
Rate 55.62% 55.62% -0.00% 66.67%
Hits 44785 44782 -3 4
Misses 35732 35730 -2 2

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 66.67% is less than the suggested 90.0%

This comment will be updated on new commits.

@jwpeterson jwpeterson merged commit f27eba2 into libMesh:devel May 9, 2022
@jwpeterson jwpeterson deleted the dirichlet_boundaries_unique_ptr branch May 9, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants