Fix the check buffer#5
Open
benjamin-voisin wants to merge 2 commits into
Open
Conversation
The check buffer command would sometimes file on large files because the curl command failed to understand the text in the command line. To fix this, we use the feature of curl to use the content of the file directly, removing the need to pass the whole content to the command line and thus not having any issue of formating, escape characters and so on. The only downside of this is that it works on the *saved* file, not on the buffer.
benjamin-voisin
force-pushed
the
fix-check-buffer
branch
from
7218263 to
e0d590e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1
The check buffer command would sometimes fail on large files because the curl command failed to understand the text in the command line. To fix this, we use the feature of curl to use the content of the file directly, removing the need to pass the whole content to the command line and thus not having any issue of formatting, escape characters and
so on.
The only downside of this is that it works on the saved file, not on the buffer. So I also updated the README to reflect this. Maybe it would be also good to change the name of the command from
LTCheckBuffertoLTCheckFileto better reflect this, but I didn't do it as it would be breaking change.