Skip to content

Deprecation updates to actions, removal of unnecessary parameterization for cmake builds. #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmienk merged 3 commits into from
Mar 25, 2026
Merged

Deprecation updates to actions, removal of unnecessary parameterization for cmake builds. #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d668a4d
Remove duplication of parameterization (with secp256k1 move to cmake,…
pmienk Mar 23, 2026
50476ab
Update to remove deprecation notice.
pmienk Mar 25, 2026
03e3471
Update to setup-msbuild@v3.
pmienk Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ jobs:

- name: Prepare toolchain [windows]
if: ${{ startsWith(matrix.os, 'windows') }}
uses: microsoft/setup-msbuild@v1.1
uses: microsoft/setup-msbuild@v3

- name: Build gsl [macos]
if: ${{ startsWith(matrix.os, 'macos') }}
Expand Down
8 changes: 1 addition & 7 deletions templates/gsl.ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,15 +725,9 @@ endfunction # get_sln_tests
. endif
. # assert (ndebug)
if [[ ${{ matrix.assert }} == 'ndebug' ]]; then
. if defined(my.config.cmake)
echo "ASSERT_NDEBUG=--enable-ndebug -Denable-ndebug=yes" >> $GITHUB_ENV
else
echo "ASSERT_NDEBUG=--disable-ndebug -Denable-ndebug=no" >> $GITHUB_ENV
. else
echo "ASSERT_NDEBUG=--enable-ndebug" >> $GITHUB_ENV
else
echo "ASSERT_NDEBUG=--disable-ndebug" >> $GITHUB_ENV
. endif
fi
. # link
if [[ ${{ matrix.link }} == 'dynamic' ]]; then
Expand Down Expand Up @@ -936,7 +930,7 @@ endfunction # get_sln_tests

steps:
- name: Add msbuild to PATH
uses: microsoft/setup-msbuild@v2
uses: microsoft/setup-msbuild@v3
with:
msbuild-architecture: x64

Expand Down