Remove multi-threading support#93
Merged
danielocfb merged 1 commit intolibbpf:masterfrom Mar 22, 2023
danielocfb:topic/no-crossbeam
Merged
Remove multi-threading support#93danielocfb merged 1 commit intolibbpf:masterfrom danielocfb:topic/no-crossbeam
danielocfb merged 1 commit intolibbpf:masterfrom
danielocfb:topic/no-crossbeam
Conversation
We have some limited support for doing DWARF parsing with multiple
threads in debug_info_parse_symbols(), but it is not currently used
anywhere but tests/benchmarks. I adjusted the resolver to use four
instead of only a single thread but performance of our end-to-end test
was unaffected:
dwarf/dwarf :: lookup_end_to_end
time: [38.452 ms 38.729 ms 39.055 ms]
change: [+0.4597% +1.5175% +2.5883%] (p = 0.00 < 0.02)
Change within noise threshold.
Found 50 outliers among 500 measurements (10.00%)
24 (4.80%) high mild
26 (5.20%) high severe
dwarf/dwarf :: symbolize_end_to_end
time: [7.8156 ms 7.8725 ms 7.9420 ms]
change: [-0.7813% +0.0273% +0.9428%] (p = 0.95 > 0.02)
No change in performance detected.
Found 43 outliers among 500 measurements (8.60%)
16 (3.20%) high mild
27 (5.40%) high severe
This change removes this multi-threaded code as it was not actually
usable by users and consumed an additional dependency. We can resurrect
it if truly needed, but APIs should likely be designed differently and
not spawn thread internally.
Signed-off-by: Daniel Müller <deso@posteo.net>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 68.84% 68.74% -0.11%
==========================================
Files 13 13
Lines 4260 4204 -56
==========================================
- Hits 2933 2890 -43
+ Misses 1327 1314 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
anakryiko
approved these changes
Mar 22, 2023
Member
anakryiko
left a comment
anakryiko
left a comment
There was a problem hiding this comment.
Discussed this offline. It's surprising multi-threading doesn't help, so we'll need to circle back to this at some point. For now let's record an issue to add multi-threaded support later on to not forget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some limited support for doing DWARF parsing with multiple threads in debug_info_parse_symbols(), but it is not currently used anywhere but tests/benchmarks. I adjusted the resolver to use four instead of only a single thread but performance of our end-to-end test was unaffected:
This change removes this multi-threaded code as it was not actually usable by users and consumed an additional dependency. We can resurrect it if truly needed, but APIs should likely be designed differently and not spawn threads internally.