Fix small issues 2#209
Merged
brarcher merged 16 commits intolibcheck:masterfrom Sep 9, 2019
Merged
Conversation
mikkoi
force-pushed
the
fix-small-issues-2
branch
from
4b72c2a to
ade548e
Compare
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
mikkoi
force-pushed
the
fix-small-issues-2
branch
from
ade548e to
ed6ddb4
Compare
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Function _exit(int) is included in unistd.h. Also fork() is here. Functions exit(int) (C89) and _Exit(int) (C99) are in stdlib.h. Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
If we don't undefine the macro, it will enter the user's namespace. This macro is only for our internal use. Otherwise it would have the "CK_" prefix. Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
It is a CMake best practice to include file 'CTest' in the project main file and then use option 'BUILD_TESTING' (defined in 'CTest') to enable or disable building the tests. BUILD_TESTING is ON by default. https://cmake.org/cmake/help/v3.9/module/CTest.html?highlight=build_testing https://cmake.org/cmake/help/v3.9/command/add_test.html?highlight=build_testing Option CHECK_ENABLE_TESTS is deprecated. Because it is on by default, deprecation warning is only shown to user when user explicitly turns CHECK_ENABLE_TESTS off. Suggesting to remove the option by release 0.15.0. Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
mikkoi
force-pushed
the
fix-small-issues-2
branch
from
e1faee2 to
e17c6f7
Compare
Restrict variable replacement to references of the form @var@. This is useful for configuring scripts that also use ${VAR} syntax. Adding @only is precautionary action to prevent future bugs. Attn. cmake/config.h.in contains ${VAR} in #cmakedefine clauses! How to use CMake variable substitution. Wrong: #if @HAVE_FORK@ [..] #endif Because this will result as: #if 1 [..] #endif Better: /* Imported CMake variables created during build. */ #cmakedefine HAVE_FORK 1 #ifdef HAVE_FORK [..] #endif Because this will result as: /* Imported CMake variables created during build. */ #define HAVE_FORK 1 #ifdef HAVE_FORK [..] #endif Or: /* Imported CMake variables created during build. */ /* #undef HAVE_FORK */ [..] This is more readable. Now we know which decision actually was taken. If you need to pass the parameter to the definition, it is just as easy: /* Imported CMake variables created during build. */ #cmakedefine CORRECT_SIZE @CORRECT_SIZE@ #if CORRECT_SIZE >= 20 [..] #endif Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
mikkoi
force-pushed
the
fix-small-issues-2
branch
from
9042980 to
1f7d1c1
Compare
brarcher
reviewed
Sep 8, 2019
Will not convert m4/ax_create_stdint_h.m4 to CMake. Make the resulting check_stdint.h similar to the old one (as much as is possible). GNU Autotools build is untouched. It continues to use m4 macro and generates check_stdint.h from scratch. Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
mikkoi
force-pushed
the
fix-small-issues-2
branch
from
829c9ff to
a77491a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix several minor issues, needed before we go into fixing the rest of the build for POSIX compatibles.