-
Notifications
You must be signed in to change notification settings - Fork 80
Add dense_longlong to all integer dtype parameters #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d7e2829
d03fecf
9fbd7b8
f0906e9
7527389
f37a316
9525b3d
31f0224
bb7efa3
3addcec
1e76609
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,9 +31,10 @@ Examples | |
|
|
||
| npe_function(bfs_orient) | ||
| npe_doc(ds_bfs_orient) | ||
| npe_arg(f, dense_int, dense_long) | ||
| npe_arg(f, dense_int, dense_long, dense_longlong) | ||
| npe_begin_code() | ||
|
|
||
| //assert_valid_tet_or_tri_mesh_faces(f, "f"); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why commented? |
||
| npe_Matrix_f ff, c; | ||
| igl::bfs_orient(f, ff, c); | ||
| return std::make_tuple(npe::move(ff), npe::move(c)); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,9 +30,11 @@ Examples | |
|
|
||
| npe_function(boundary_facets) | ||
| npe_doc(ds_boundary_facets) | ||
| npe_arg(t, dense_int, dense_long) | ||
| npe_arg(t, dense_int, dense_long, dense_longlong) | ||
| npe_begin_code() | ||
|
|
||
| // TODO: need an option for multiple shapes | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you elaborate?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here t can be either #t by 3 or #t by 4, and currently I think we cannot check this
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh right |
||
| assert_cols_equals(t, 3, "t"); | ||
| EigenDense<npe_Scalar_t> f; | ||
| igl::boundary_facets(t, f); | ||
| return npe::move(f); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,9 +30,10 @@ Examples | |
|
|
||
| npe_function(boundary_loop) | ||
| npe_doc(ds_boundary_loop) | ||
| npe_arg(f, dense_int, dense_long) | ||
| npe_arg(f, dense_int, dense_long, dense_longlong) | ||
| npe_begin_code() | ||
|
|
||
| //assert_valid_tet_or_tri_mesh_faces(f, "f"); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why? |
||
| EigenDenseLike<npe_Matrix_f> l; | ||
| igl::boundary_loop(f, l); | ||
| return npe::move(l); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| #include <common.h> | ||
| #include <npe.h> | ||
| #include <typedefs.h> | ||
| #include <igl/circumradius.h> | ||
|
|
@@ -34,11 +35,12 @@ npe_function(circumradius) | |
| npe_doc(ds_circumradius) | ||
|
|
||
| npe_arg(v, dense_float, dense_double) | ||
| npe_arg(f, dense_int, dense_long) | ||
| npe_arg(f, dense_int, dense_long, dense_longlong) | ||
|
|
||
|
|
||
| npe_begin_code() | ||
|
|
||
| assert_valid_tet_or_tri_mesh(v, f); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if it is by 3 it is tri_mesh3d not tets |
||
| EigenDense<npe_Scalar_v> r; | ||
| igl::circumradius(v, f, r); | ||
| return npe::move(r); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| // TODO: __example | ||
|
|
||
| #include <common.h> | ||
| #include <npe.h> | ||
| #include <typedefs.h> | ||
| #include <igl/connect_boundary_to_infinity.h> | ||
|
|
@@ -34,11 +35,12 @@ Examples | |
| npe_function(connect_boundary_to_infinity) | ||
| npe_doc(ds_connect_boundary_to_infinity) | ||
|
|
||
| npe_arg(f, dense_int, dense_long) | ||
| npe_arg(f, dense_int, dense_long, dense_longlong) | ||
|
|
||
|
|
||
| npe_begin_code() | ||
|
|
||
| //assert_valid_3d_tri_mesh_faces(f, "f"); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? |
||
| npe_Matrix_f fo; | ||
| igl::connect_boundary_to_infinity(f, fo); | ||
| return npe::move(fo); | ||
|
|
@@ -74,11 +76,12 @@ npe_function(connect_boundary_to_infinity_face) | |
| npe_doc(ds_connect_boundary_to_infinity_face) | ||
|
|
||
| npe_arg(v, dense_float, dense_double) | ||
| npe_arg(f, dense_int, dense_long) | ||
| npe_arg(f, dense_int, dense_long, dense_longlong) | ||
|
|
||
|
|
||
| npe_begin_code() | ||
|
|
||
| //assert_valid_3d_tri_mesh_faces(f, "f"); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? |
||
| npe_Matrix_v vo; | ||
| npe_Matrix_f fo; | ||
| igl::connect_boundary_to_infinity(v, f, vo, fo); | ||
|
|
@@ -118,12 +121,13 @@ Examples | |
| npe_function(connect_boundary_to_infinity_index) | ||
| npe_doc(ds_connect_boundary_to_infinity_index) | ||
|
|
||
| npe_arg(f, dense_int, dense_long) | ||
| npe_arg(f, dense_int, dense_long, dense_longlong) | ||
| npe_arg(inf_index, int) | ||
|
|
||
|
|
||
| npe_begin_code() | ||
|
|
||
| //assert_valid_3d_tri_mesh_faces(f, "f"); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? |
||
| npe_Matrix_f fo; | ||
| igl::connect_boundary_to_infinity(f, inf_index, fo); | ||
| return npe::move(fo); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also tet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is by simplex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are indeed correct