Skip to content

Remove unnecessary copy #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alecjacobson merged 2 commits into from
Feb 12, 2023
Merged

Remove unnecessary copy #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f43fa16
remove copy after libigl fix
alecjacobson Feb 11, 2023
7f2c85e
bump libigl
alecjacobson Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/PyiglDependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ include(FetchContent)
FetchContent_Declare(
libigl
GIT_REPOSITORY https://github.com/libigl/libigl.git
GIT_TAG 78015d4da1c6799dfe15659ed35adfb3a5f23ffa
GIT_TAG 7e5512ce71d7394ba965964f66e9a9d91597e767
)
FetchContent_GetProperties(libigl)
FetchContent_MakeAvailable(libigl)
Expand Down
5 changes: 1 addition & 4 deletions src/copyleft/cgal/convex_hull.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@ npe_arg(v, dense_float, dense_double)
npe_begin_code()

EigenDenseInt g;
// when https://github.com/libigl/libigl/pull/1989 is merged this copy should
// be removed
Eigen::MatrixXd v_copy = v.template cast<double>();
igl::copyleft::cgal::convex_hull(v_copy, g);
igl::copyleft::cgal::convex_hull(v, g);
return npe::move(g);

npe_end_code()