Skip to content

fixes #124#125

Merged
timotheecour merged 2 commits intolibmir:masterfrom
timotheecour:pr_fix_slice_error
Feb 21, 2018
Merged

fixes #124#125
timotheecour merged 2 commits intolibmir:masterfrom
timotheecour:pr_fix_slice_error

Conversation

@timotheecour
Copy link
Collaborator

@timotheecour timotheecour commented Feb 19, 2018

fixes #124
fixes #126

OLD

@9il please double check this is doing the right thing
Also, should the right thing to do be to make I = sizediff_t in the other iota functions in mir.ndslice.topology?

Slice!(Contiguous, [N], IotaIterator!I)
iota
    (I, size_t N)(size_t[N] lengths, I start)
    if (isIntegral!I || isPointer!I)

Slice!(Contiguous, [N], StrideIterator!(IotaIterator!I))
iota
    (I, size_t N)(size_t[N] lengths, I start, size_t stride)
    if (isIntegral!I || isPointer!I)

so that
iota!ptrdiff_t([kh], shape[0] - kh) would just be equivalent to iota([kh], shape[0] - kh) ?

@9il
Copy link
Member

9il commented Feb 20, 2018

Also, should the right thing to do be to make I = sizediff_t in the other iota functions in mir.ndslice.topology?

Done https://github.com/libmir/mir-algorithm/releases/tag/v0.9.0

@timotheecour
Copy link
Collaborator Author

/cc @9il PTAL

@codecov-io
Copy link

codecov-io commented Feb 20, 2018

Codecov Report

Merging #125 into master will decrease coverage by 1.03%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #125      +/-   ##
=========================================
- Coverage   61.54%   60.5%   -1.04%     
=========================================
  Files          24      24              
  Lines        2642    2537     -105     
=========================================
- Hits         1626    1535      -91     
+ Misses       1016    1002      -14

@timotheecour timotheecour merged commit 7b07d40 into libmir:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update to mir-algorithm v0.9.1 core/utils.d(72,23): Error: cannot implicitly convert expression iota([shape[0]])

3 participants