Merged
Conversation
Member
Done https://github.com/libmir/mir-algorithm/releases/tag/v0.9.0 |
Collaborator
Author
|
/cc @9il PTAL |
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=========================================
- Coverage 61.54% 60.5% -1.04%
=========================================
Files 24 24
Lines 2642 2537 -105
=========================================
- Hits 1626 1535 -91
+ Misses 1016 1002 -14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #124
fixes #126
OLD
@9il please double check this is doing the right thing
Also, should the right thing to do be to make
I = sizediff_tin the other iota functions in mir.ndslice.topology?so that
iota!ptrdiff_t([kh], shape[0] - kh)would just be equivalent toiota([kh], shape[0] - kh)?