add: yamux #268
Merged
add: yamux #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marten-seemann
left a comment
marten-seemann
left a comment
There was a problem hiding this comment.
Can you also add a paragraph saying that yamux is the better choice than mplex, similar to what I suggested adding to mplex?
We've had people in the past use mplex instead of yamux, just because they weren't aware of the differences, and it would be nice if we could point them into the right direction.
salmad3
added
change request
salmad3
added
ready for review
Contributor
Author
|
@marten-seemann can be checked again. |
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
marten-seemann
approved these changes
Jan 31, 2023
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Notes
Latest preview
Please view the latest Fleek preview here.