feat: early muxer negotiation #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-shahi
reviewed
Jan 11, 2023
p-shahi
reviewed
Jan 11, 2023
| Multistream-select will run again on top of | ||
| the secure channel to negotiate a steam muxer, like [yamux](yamux). | ||
|
|
||
| <!-- ADD DIAGRAM --> |
Contributor
There was a problem hiding this comment.
Are we planning to merge without resolving this TODO? Should we create an issue so we don't forget?
Contributor
Author
There was a problem hiding this comment.
I have them noted down, and will also add to the issue open about unified diagrams.
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com> Co-authored-by: Marten Seemann <martenseemann@gmail.com>
salmad3
commented
Jan 11, 2023
Contributor
|
Looks like there are still a bunch of comments to address, please request another review when done. |
Contributor
Author
I had replied to the comments or added counter suggestions. |
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
p-shahi
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Latest preview
Please view the latest Fleek preview here.