feat: identify #286
Merged
feat: identify #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marten-seemann
left a comment
marten-seemann
left a comment
There was a problem hiding this comment.
We should also mention that there's a Identify Delta that go-libp2p shipped with for some time, and that we recently deprecated because we found that it's not particularly useful, but introduced a lot of complexity.
| remote node and the remote node responds with an `Identify` message containing | ||
| its metadata and closes the stream. | ||
|
|
||
| <!-- ADD Diagram --> |
Contributor
There was a problem hiding this comment.
Not sure if we need one, this should be really straightforward.
Contributor
Author
There was a problem hiding this comment.
I had sketched simple diagrams, one for identity and identify/push.
salmad3
added
change request
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
salmad3
added
ready for review
mxinden
approved these changes
Feb 20, 2023
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Pushed a couple of adjustments. This is good to go from my end.
p-shahi
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adds identify content to protocols section.
Latest preview
Fleek preview unavailable as PR not against master.