[multistream-select] Re-enable 'parallel negotiation'.#1934
Merged
romanb merged 2 commits intolibp2p:masterfrom Mar 1, 2021
Merged
[multistream-select] Re-enable 'parallel negotiation'.#1934romanb merged 2 commits intolibp2p:masterfrom
romanb merged 2 commits intolibp2p:masterfrom
Conversation
Based on an estimate of the number of alternative protocols the dialer supports.
mxinden
approved these changes
Jan 26, 2021
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Change looks good to me.
As far as I can tell the last patch of the series (#1811) is deployed with the recent Polkadot release v0.8.27.
I would expect it to be too early to break compatibility with versions < v0.8.27. What do you think? If so, I would suggest not yet merging this pull request until Polkadot v0.8.28 is released.
Contributor
Author
Sounds good to me. |
Member
|
With Polkadot v0.8.28-1 released, I think we can move forward here. Any objections @romanb @tomaka? |
Contributor
Author
|
I will go ahead with merging this today if there are no objections. |
Contributor
Author
|
Published in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-enables the "parallel negotiation" strategy for the dialer in
multistream-selectbased on an estimate of the number of alternative protocols the dialer supports. In this strategy the dialer sends anlsrequest straight away to avoid repeated protocol proposals and roundtrips. Closes #1847.