Closed
Conversation
Member
Author
|
Arg, I accidentally included a rustfmt as well. |
Member
Author
|
Closing in favor of the alternative approach in #472 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on top of #459
The swarm now calls
tokio_executor::spawnto create tasks.This PR is not intended to be merged, and is set aside. It's not sure whether it's worth pushing this way.
We have one task that polls all the incoming substreams of all connections, as the API of the muxed transport doesn't allow otherwise.
The only proper way to do things correctly is remove the connection reuse and rework the swarm entirely.