This repository was archived by the owner on Dec 11, 2023. It is now read-only.
Add basic GET support for composite metrics #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderrett
added a commit
that referenced
this pull request
Jan 21, 2015
Add basic GET support for composite metrics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
get_composite()method to theLibratoConnectionclass which returns adictcontaining the composite response. This is impemented in a manner similar to librato/librato-metrics#103 and does not attempt to formalize composites into an object-oriented structure. Rather, we're just returning the hash of values from the API response.Fixes #57