-
Notifications
You must be signed in to change notification settings - Fork 110
Fix Pirania issue/1206 and overall captive portal stability #1224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…irania script functionality
|
Hey, nice work @usg-ishimura! |
|
Hi @henmohr, |
This PR addresses issue #1206, before this changes when a client connected to a secondary node's AP, the primary node's (wan) nftables received the source mac address of the secondary node itself instead of the client's, blocking in fact internet access for the client even after the authentication process via voucher or read for access. I chose an hybrid solution to the problem checking that ips and macs of the clients are in the authorized lists and adding secondary nodes ips and macs to the whitelists by default. So when a client connects to a secondary node AP the elements in the whitelists should be the mac address of the secondary node and the ip of the client, when a client connects to a primary node AP the elements in the whitelists should be the mac address of the client and the ip of the client. This PR contains the commits from #1219 so i'm closing that one.
This PR can be tested adding this repo in the feeds
src-git libremesh https://github.com/usg-ishimura/lime-packages.git;issue/1206
The update works with my GL-AR300M16 routers on OpenWrt v23.05.5 but it needs further testing for sure.