Removal of lime-full mentions #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilario
requested review from
G10h4ck,
aparcar,
gmarcos87,
nicopace and
spiccinini
nicopace
reviewed
Jun 22, 2019
| CONFIG_PACKAGE_bmx7-auto-gw-mode=m | ||
| CONFIG_LIMEWEBUI_ES=y | ||
| CONFIG_PACKAGE_lime-app=m | ||
| CONFIG_PACKAGE_luci=m |
Contributor
There was a problem hiding this comment.
this is outside of the fix.
please remove... apart from that, awesome!
Member
Author
There was a problem hiding this comment.
...luci was also selected by lime-full (see here).
Do you confirm that we don't want this to be included in the SDK packages?
Contributor
There was a problem hiding this comment.
Not yet I believe. thanks for catching that!
nicopace
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lime-fullmetapackage has been removed in libremesh/lime-packages#513.In lime-sdk it was mentioned in
flavors.confas a part oflime_defaultandlime_newui_testand inlibremesh.sdk.config.In the first file I just expanded with the packages which were selected by
lime-full.In the second file
lime-fullwas selected twice: as=yand also as=mwhich is weird.Anyway I added what was missing (including
luci, is it ok?) and removed thelime-fulllines.