Skip to content

mac: fix behaviour of hid_get_feature_report (was writing on the repo…#3

Merged
Qbicz merged 1 commit intolibusb:masterfrom
z3ntu:pr_219
Jun 5, 2019
Merged

mac: fix behaviour of hid_get_feature_report (was writing on the repo…#3
Qbicz merged 1 commit intolibusb:masterfrom
z3ntu:pr_219

Conversation

@z3ntu
Copy link
Collaborator

@z3ntu z3ntu commented Jun 5, 2019

…rt id byte) and return value was not right)

Re-open of signal11/hidapi#219

@Qbicz Qbicz requested review from Qbicz, Youw and todbot June 5, 2019 07:41
@Qbicz Qbicz added the bug Something isn't working label Jun 5, 2019
Copy link
Member

@Youw Youw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After going over the comments in original PR and the documentation - the change looks reasonable.
Unfortunately I cannot try and verify myself, so I'd wait for someone's else opinion.

@Qbicz
Copy link
Member

Qbicz commented Jun 5, 2019

It looks reasonable to make the behaviour similar on Mac as it is on Windows and Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working macOS Related to macOS backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants