Conversation
Avoid infinite reading from the device if the device doesn't send any interrupt reports. Otherwise hidtest has to be stopped by Ctrl+C interruption, which doesn't give a chance to close the device properly, as a result this has negative side-effects when using LIBUSB backed.
Member
Author
Member
|
The change to hidtest is good to have so that user do not need to hit CTRL-C. But somehow the kernerl driver does not seem to re-attach. |
mcuee
approved these changes
Aug 14, 2022
Member
mcuee
left a comment
There was a problem hiding this comment.
Even though it does not sort out the kernel driver re-attach issue (probably another issue to sort out), this chage itself is good to have.
Member
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid infinite reading from the device if the device doesn't send any interrupt reports.
Otherwise hidtest has to be stopped by Ctrl+C interruption, which doesn't give a chance to close the device properly,
as a result this has negative side-effects when using LIBUSB backed.