linux: Open files with O_CLOEXEC to not leak fds to child processes#446
Merged
Youw merged 1 commit intolibusb:masterfrom Aug 21, 2022
Merged
linux: Open files with O_CLOEXEC to not leak fds to child processes#446Youw merged 1 commit intolibusb:masterfrom
O_CLOEXEC to not leak fds to child processes#446Youw merged 1 commit intolibusb:masterfrom
Conversation
In general, `open()` should always be called with `O_CLOEXEC`, except
immediately before an `exec*` call that will use the fd.
Previously the fd was leaked to a child process, as seen here:
```c
int main() {
assert(hid_open_path("/dev/hidraw0") > 0);
char *args[] = {"/bin/sh", "-c", "readlink /proc/self/fd/*", NULL};
execve("/bin/sh", args, NULL);
}
```
In some cases this could be a security issue if child processes may be
less privileged and shouldn't have access to the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general,
open()should always be called withO_CLOEXEC, except immediately before anexec*call that will use the fd.Previously the fd was leaked to a child process, as seen here:
In some cases this could be a security issue if child processes may be less privileged and shouldn't have access to the file.