Skip to content

Fix "warning C4996: 'wcsncpy': This function or variable may be unsafe." by using wcsncpy_s instead #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoergAtGithub wants to merge 1 commit into from
Closed

Fix "warning C4996: 'wcsncpy': This function or variable may be unsafe." by using wcsncpy_s instead #468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions windows/hid.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,9 +1182,13 @@ int HID_API_EXPORT_CALL HID_API_CALL hid_get_manufacturer_string(hid_device *dev
return -1;
}

wcsncpy(string, dev->device_info->manufacturer_string, maxlen);
errno_t err = wcsncpy_s(string, maxlen, dev->device_info->manufacturer_string, MAX_STRING_WCHARS);
string[maxlen - 1] = L'\0';

if (err) {
register_string_error(dev, L"Buffer to small");
}

register_string_error(dev, NULL);

return 0;
Expand All @@ -1202,9 +1206,13 @@ int HID_API_EXPORT_CALL HID_API_CALL hid_get_product_string(hid_device *dev, wch
return -1;
}

wcsncpy(string, dev->device_info->product_string, maxlen);
errno_t err = wcsncpy_s(string, maxlen, dev->device_info->product_string, MAX_STRING_WCHARS);
string[maxlen - 1] = L'\0';

if (err) {
register_string_error(dev, L"Buffer to small");
}

register_string_error(dev, NULL);

return 0;
Expand All @@ -1222,9 +1230,13 @@ int HID_API_EXPORT_CALL HID_API_CALL hid_get_serial_number_string(hid_device *de
return -1;
}

wcsncpy(string, dev->device_info->serial_number, maxlen);
errno_t err = wcsncpy_s(string, maxlen, dev->device_info->serial_number, MAX_STRING_WCHARS);
string[maxlen - 1] = L'\0';

if (err) {
register_string_error(dev, L"Buffer to small");
}

register_string_error(dev, NULL);

return 0;
Expand Down