Skip to content

Fix BSTArray operator= and add keyword management helpers#22

Merged
qudix merged 10 commits intolibxse:mainfrom
Zzyxz:main
Apr 18, 2026
Merged

Fix BSTArray operator= and add keyword management helpers#22
qudix merged 10 commits intolibxse:mainfrom
Zzyxz:main

Conversation

@Zzyxz
Copy link
Copy Markdown
Contributor

@Zzyxz Zzyxz commented Apr 18, 2026

This PR fixes an issue in BSTArray where the copy and move assignment operators were missing a return value, causing compiler error C4716.

Changes:

  • Fixed BSTArray::operator= by adding missing return *this
  • Added AddKeyword and RemoveKeyword to BGSKeywordForm
  • Added HasKeyword helper function

Zzyxz added 3 commits April 18, 2026 20:50
…tors

Fixes compiler error C4716 ("must return a value") when BSTArray operator= is instantiated.
Comment thread src/RE/B/BGSKeywordForm.cpp Outdated
Comment thread src/RE/B/BGSKeywordForm.cpp Outdated
Comment thread src/RE/B/BGSKeywordForm.cpp Outdated
Comment thread include/RE/B/BGSKeywordForm.h Outdated
Zzyxz and others added 7 commits April 18, 2026 21:11
Co-authored-by: qudix <17361645+qudix@users.noreply.github.com>
Co-authored-by: qudix <17361645+qudix@users.noreply.github.com>
Co-authored-by: qudix <17361645+qudix@users.noreply.github.com>
Co-authored-by: qudix <17361645+qudix@users.noreply.github.com>
@qudix qudix merged commit a7be04b into libxse:main Apr 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants