Open
Conversation
|
Looks good to me! Anybody else have other thoughts? |
README.md
Outdated
There was a problem hiding this comment.
Might want to revisit this sentence: "This prevents us to have to worry about formatting and is more explicit"
Author
|
@doomspork or @bdoms Please review and merge if happy. |
There was a problem hiding this comment.
Should this example also be changed to match the new style above?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per @bdoms suggestion of being explicit on variable declarations.
Article @bdoms referenced: http://benalman.com/news/2012/05/multiple-var-statements-javascript/
I also had the ingenious idea of pushing this to airBnB (by accident), and we got some nice feedback from a couple of their engineers as well: airbnb#143
@doomspork @GabKlein @amdtech @jmacadam @jcarouth feel free to debate if you want. I am neutral on this one.