Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

explicitly depend on Akka HTTP#104

Merged
eed3si9n merged 1 commit intomasterfrom
wip/akka-http
Jan 6, 2019
Merged

explicitly depend on Akka HTTP#104
eed3si9n merged 1 commit intomasterfrom
wip/akka-http

Conversation

@eed3si9n
Copy link
Contributor

@eed3si9n eed3si9n commented Jan 6, 2019

Ref https://discuss.lightbend.com/t/no-configuration-setting-found-for-key-decode-max-size/2738
Fixes #103
Fixes lagom/lagom#1652

explicitly depend on Akka HTTP to bring in 10.1.5 to avoid No configuration setting found for key 'decode-max-size'.

Ref https://discuss.lightbend.com/t/no-configuration-setting-found-for-key-decode-max-size/2738
Fixes #103
Fixes lagom/lagom#1652

explicitly depend on Akka HTTP to bring in 10.1.5 to avoid No configuration setting found for key 'decode-max-size'.
@ghost ghost assigned eed3si9n Jan 6, 2019
@ghost ghost added the review label Jan 6, 2019
@eed3si9n eed3si9n merged commit 031bd2f into master Jan 6, 2019
@ghost ghost removed the review label Jan 6, 2019
@eed3si9n eed3si9n deleted the wip/akka-http branch January 6, 2019 04:02
@TimMoore
Copy link

TimMoore commented Jan 7, 2019

So I guess this means that it breaks compatibility with Lagom 1.4.x, but it didn't actually change the Lagom dependency. I'm not sure that this is actually the best solution. Wasn't the problem fixed upstream in Akka HTTP?

@TimMoore
Copy link

TimMoore commented Jan 7, 2019

Here's where that was fixed: akka/akka-http#2307

AFAIK reactive-lib did not need this change. @renatocaval can you comment?

@octonato
Copy link
Member

octonato commented Jan 7, 2019

Lagom 1.4.9 is using akka-http 10.0.14 and is affected by the decode-max-size property issue because that config was backported to akka-http 10.0.14.

We need a reactive-lib version tailored for Lagom 1.4.x, depending on akka-http 10.0.14 and akka-management 0.20.
Or even better, reactive-lib should not need to depend directly on akka-http, but on akka-management 0.21 that itself should depends on akka-http 10.0.14.

Then, for Lagom 1.5.x, we need it depending on akka-management 0.50 and transitively on akka-http 10.1.6.

@eed3si9n
Copy link
Contributor Author

eed3si9n commented Jan 7, 2019

I tested with online auction 1.4.x branch and looked ok, but I'd be happy to bump Akka Management when 0.21.0 is available.

@eed3si9n
Copy link
Contributor Author

eed3si9n commented Jan 7, 2019

For now should I depend on Akka HTTP 10.0.14 so it's aligned with Lagom 1.4.x at least?

@octonato
Copy link
Member

octonato commented Jan 7, 2019

There is already an akka-http 10.0.15.

So yea, if we plan to cut a release for Lagom 1.4.x based on akka-management 0.20, then better to depend on akka-http 10.0.15. Lagom 1.4.10 will be based on 10.0.15.

I'm not sure if we are going to have an akka-mgnt 0.21 with 10.0.15. (cc @chbatey / @patriknw)

eed3si9n added a commit that referenced this pull request Jan 7, 2019
Ref #104, #103
Ref https://discuss.lightbend.com/t/no-configuration-setting-found-for-key-decode-max-size/2738
Ref lagom/lagom#1652

As per recommendation by Play/Lagom team, I am downgrading the Akka HTTP to 10.0.15, which aligns with Lagom 1.4.x, as opposed to 10.1.5 that's compatible with Lagom 1.5.x.
@eed3si9n eed3si9n added this to the 1.6.0 milestone Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants