Bolt 7 edit#307
Closed
shannona wants to merge 9 commits into
Closed
Conversation
added 9 commits
November 29, 2017 14:54
Besides standard edits and clarification, there were some notable rewrites in the "Our Offers" and "Their Offers" sections that will need to be examined very carefully. They had to do with opaque and sometimes inconsistent use of "our" and "their". There's additional explanation in email.
Some fixes to the pull request based on Rusty's comments.
Besides standard edits and clarification, there were some notable rewrites in the "Our Offers" and "Their Offers" sections that will need to be examined very carefully. They had to do with opaque and sometimes inconsistent use of "our" and "their". There's additional explanation in email.
Some fixes to the pull request based on Rusty's comments.
Edits per @toadlyBroodle's review.
Better text for that one section where I disagreed with the review.
A variety of edits, mostly cleanup.
Collaborator
Author
|
I think I have a cleaner branch; I'm going to try and close this and open a better one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are edits to BOLT-7. Unfortunately, my master had the old BOLT-5 edits in there, so those got pulled in. The BOLT-5 stuff can thus be ignored, and if you'd prefer me to submit a fresh pull for BOLT-7, just let me know (and I'll see if I can get things better sorted on my side).