Edits for BOLT-07#308
Conversation
| but multiple `node_announcement` messages are possible (to update node | ||
| information), and at least two `channel_update` messages are expected. | ||
| To support node discovery, peers exchange `node_announcement` | ||
| messages, which supply additional information about nodes There can be |
There was a problem hiding this comment.
Missing period between "about nodes" and "There can be"
| index which pays to the channel. | ||
| index that pays to the channel. | ||
|
|
||
| If the `open_channel` message had the `announce_channel` bit set, then both nodes must send the `announcement_signatures` message, otherwise they MUST NOT. |
| 1. D: 400 base + 4000 millionths | ||
| 2. B: 200 base + 2000 millionths | ||
| 3. C: 300 base + 3000 millionths | ||
| 4. D: 400 base + 4000 millionths |
There was a problem hiding this comment.
This is fine, but FYI, markdown turns these into an enumerated list when rendering anyway :)
| If the `open_channel` message had the `announce_channel` bit set, then both nodes must send the `announcement_signatures` message, otherwise they MUST NOT. | ||
|
|
||
| If sent, `announcement_signatures` messages MUST NOT be sent until `funding_locked` has been sent and the funding transaction has at least 6 confirmations. | ||
| The `announcement_signatures` message is created by constructing a `channel_announcement` message corresponding to the newly established channel and signing it with the secrets matching an endpoint's `node_id` and `bitcoin_key`. The message is then sent using an `announcement_signatures`. |
There was a problem hiding this comment.
...message, corresponding...channel, and...
There was a problem hiding this comment.
Yep, clearer. Fixed.
|
|
||
| If the `open_channel` message had the `announce_channel` bit set, then both nodes must send the `announcement_signatures` message, otherwise they MUST NOT. | ||
|
|
||
| If sent, `announcement_signatures` messages MUST NOT be sent until `funding_locked` has been sent and the funding transaction has at least 6 confirmations. |
| `node_2` requires: | ||
|
|
||
| 1. Prove that the funding transaction pays to `bitcoin_key_1` and | ||
| 1. Proving that the funding transaction pays to `bitcoin_key_1` and |
There was a problem hiding this comment.
proving...bitcoin_key_1 <--(no 'and')
There was a problem hiding this comment.
The whole line is actually: "1. Proving that the funding transaction pays to bitcoin_key_1 and
bitcoin_key_2."Unless there's a style I'm missing, kept.
| 2. Prove `node_1` owns `bitcoin_key_1` | ||
| 3. Prove `node_2` owns `bitcoin_key_2` | ||
| 2. Proving that `node_1` owns `bitcoin_key_1` | ||
| 3. Proving that `node_2` owns `bitcoin_key_2` |
There was a problem hiding this comment.
I think I didn't have that style update when I did 07, so keep an eye out when you get there. In any case, I've fixed all three of these lines to be no initial cap and no end period,
There was a problem hiding this comment.
(Actually, I reskimmed, and this is the only list with fragments, so we should have this now.
| We also need to prove that `node_1` and `node_2` both agree on this | ||
| announcement message; that is done by having a signature from each | ||
| It is also necessary to prove that `node_1` and `node_2` both agree on this | ||
| announcement message; that is accomplished by having a signature from each |
There was a problem hiding this comment.
...message; this is...
| announces the fees and minimum expiry delta it requires to relay HTLCs | ||
| through this channel. It uses the 8-byte | ||
| channel shortid which matches the `channel_announcement` and one bit | ||
| through this channel. They use the 8-byte |
There was a problem hiding this comment.
...channel. Each uses the...
| through this channel. It uses the 8-byte | ||
| channel shortid which matches the `channel_announcement` and one bit | ||
| through this channel. They use the 8-byte | ||
| channel shortid that matches the `channel_announcement` and one bit |
|
Updated commit: (1) addresses all reviews from @rustyrussell and @toadlyBroodle ; (2) Correctly capitalizes a few sections that had been missed; and (3) incorporates table of contents courtesy of @bcongdon in #310 |
3 participants
A variety of edits for clarity and our styles sheets for BOLT-7. The one other issue for BOLT-7 has been filed as issue #302.