Skip to content

minor: only 2 bytes for open_channel.max-num-htlcs#4

Closed
pm47 wants to merge 1 commit into
lightning:masterfrom
pm47:patch-1
Closed

minor: only 2 bytes for open_channel.max-num-htlcs#4
pm47 wants to merge 1 commit into
lightning:masterfrom
pm47:patch-1

Conversation

@pm47
Copy link
Copy Markdown
Collaborator

@pm47 pm47 commented Nov 15, 2016

do we really want to have more than 65 536 oustanding htlcs?

@cdecker
Copy link
Copy Markdown
Collaborator

cdecker commented Nov 15, 2016

I think the argument was that we want to have all the num-XXX fields to be 4 bytes, we even have some limit on outstanding HTLCs (300 IIRC), but this is for uniformity's sake :-)

@rustyrussell
Copy link
Copy Markdown
Collaborator

Christian Decker notifications@github.com writes:

I think the argument was that we want to have all the num-XXX fields to be 4 bytes, we even have some limit on outstanding HTLCs (300 IIRC), but this is for uniformity's sake :-)

Yes.bytes. Let me start a new spec on how to extend the protocol which
should explain this and much else that's assumed...

Thanks!
Rusty.

@pm47
Copy link
Copy Markdown
Collaborator Author

pm47 commented Nov 16, 2016

Great! closing this one

@pm47 pm47 closed this Nov 16, 2016
@pm47 pm47 deleted the patch-1 branch November 16, 2016 11:23
fjahr pushed a commit to fjahr/lightning-mw that referenced this pull request Dec 24, 2018
@TheBlueMatt TheBlueMatt mentioned this pull request Nov 4, 2019
ifuensan added a commit to ifuensan/bolts that referenced this pull request Apr 23, 2023
ifuensan added a commit to ifuensan/bolts that referenced this pull request May 7, 2023
erickcestari added a commit to erickcestari/bolts that referenced this pull request Mar 19, 2026
Introduce an amendment to BOLT lightning#4 specifying a Hop Count Header (HCH)
that cryptographically enforces a maximum of 20 forwarding hops for
onion messages, reducing the DoS amplification factor from ~350x to 20x.
erickcestari added a commit to erickcestari/bolts that referenced this pull request Mar 19, 2026
Introduce an amendment to BOLT lightning#4 specifying a Hop Count Header (HCH)
that cryptographically enforces a maximum of 20 forwarding hops for
onion messages, reducing the DoS amplification factor from ~350x to 20x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants