Skip to content

04-onion-routing.md: Prepare for extra onion blob encoding.#507

Closed
ZmnSCPxj wants to merge 1 commit into
lightning:masterfrom
ZmnSCPxj:realm-to-type
Closed

04-onion-routing.md: Prepare for extra onion blob encoding.#507
ZmnSCPxj wants to merge 1 commit into
lightning:masterfrom
ZmnSCPxj:realm-to-type

Conversation

@ZmnSCPxj
Copy link
Copy Markdown
Collaborator

No description provided.

@ZmnSCPxj
Copy link
Copy Markdown
Collaborator Author

I used per_hop_type instead of agree upon type, but I feel type is imprecise as we also use the same term for message ID.

@ZmnSCPxj
Copy link
Copy Markdown
Collaborator Author

I have also named per_hop_type 0 to normal_per_hop.

Comment thread 04-onion-routing.md
1. type: `hops_data`
2. data:
* [`1`:`realm`]
* [`1`:`per_hop_type`]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming suggestion: packet type?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does seem better.

@rustyrussell rustyrussell added this to the v1.1 milestone Dec 10, 2018
@t-bast
Copy link
Copy Markdown
Collaborator

t-bast commented Sep 19, 2019

Closing this old PR, superceded by #619

@t-bast t-bast closed this Sep 19, 2019
@ZmnSCPxj ZmnSCPxj deleted the realm-to-type branch September 20, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants