tools: update CSV generator to output fields for tlv's and subtypes#597
Closed
niftynei wants to merge 5 commits into
Closed
tools: update CSV generator to output fields for tlv's and subtypes#597niftynei wants to merge 5 commits into
niftynei wants to merge 5 commits into
Conversation
v1.1 message formats add new types (tlv's and subtypes). this updates the csv extraction tool to appropriately output them
niftynei
added a commit
to niftynei/lightning
that referenced
this pull request
Apr 3, 2019
Updated to match what the CSV generator in the RFC repo actually outputs, see lightning/bolts#597
rustyrussell
pushed a commit
to ElementsProject/lightning
that referenced
this pull request
Apr 3, 2019
Updated to match what the CSV generator in the RFC repo actually outputs, see lightning/bolts#597
rustyrussell
requested changes
Apr 8, 2019
Collaborator
rustyrussell
left a comment
rustyrussell
left a comment
There was a problem hiding this comment.
It'd be nice to have the output form listed somewhere too (it's currently pretty undocumented).
| else: | ||
| print("{},{}".format( | ||
| match.group('name'), | ||
| str(match.group('value') or '$')), file=output) |
Collaborator
There was a problem hiding this comment.
I think subtypes should just be a single field, ie. no value. Rather than a double field with a magic '$' sign?
subtypes used to use a magic '$' to designate that they were embedded; now we print them without magic. previous: input_info,$ input_info,0,xxx now: input_info input_info,0,xxx previous: funding_message,2,field,8 funding_message,10,num_inputs,2 funding_message,12,input_info,$num_inputs now: funding_message,2,field,8 funding_message,10,num_inputs,2 funding_message,12,input_info,num_inputs*input_info
For example, @cdecker used a FRAME_SIZE constant in lightning#593 which broke parsing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
approved these changes
May 6, 2019
Collaborator
Collaborator
|
ACK 33ff459 |
1. Uses 'tlvs' for the "length" of tlv streams. 2. Allow - inside length of fields, since it's useful given an implied tlv_len. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Collaborator
|
I think this was rolled into #622 ? |
Collaborator
|
Closed in favor of #622 which was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.1 message formats add new types (tlv's and subtypes). this updates
the csv extraction tool to appropriately output them