Simple tooling fixes#650
Merged
Merged
Conversation
niftynei
approved these changes
Jul 22, 2019
The format for TLV types looked pretty, but @ZmnSCPxj points out that successive ordered lists in markdown get merged into one megalist. If we allow ordered or unordered lists, we're a bit more futureproof against formatting changes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
In practice, using '...*type' is the clearest and simplest way to specify the common case of "the rest of the TLV is an array of 'type'", rather than some arbitrary expression with a made-up length field. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/tooling-fixes
branch
from
80cef74 to
d08b26f
Compare
t-bast
approved these changes
Aug 5, 2019
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first two are in #631 already, but the third one is new: @ZmnSCPxj points out in #643 that describing TLVs using ordered lists causes them to be merged on formatting, so we should use unordered lists (which is also logically consistent).