BOLT 4: add a requirement of tlv_payload payload format#691
Closed
nayuta-gondo wants to merge 1 commit into
Closed
BOLT 4: add a requirement of tlv_payload payload format#691nayuta-gondo wants to merge 1 commit into
tlv_payload payload format#691nayuta-gondo wants to merge 1 commit into
Conversation
cfromknecht
reviewed
Oct 30, 2019
|
|
||
| The reader: | ||
| - MUST return an error if `amt_to_forward` or `outgoing_cltv_value` are not present. | ||
| - MUST return an error if it is not the final node and `short_channel_id` is not present. |
Collaborator
There was a problem hiding this comment.
should we also return an error if a node is the final hop and short_channel_id is present?
Collaborator
niftynei
added
the
clarification
Collaborator
|
I believe this was fixed by #643 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.