Specify that resolution of amount is msat#700
Conversation
When the `p` multiplier is used, the amount MUST be divisible by 10 since the resolution used internally is millisatoshi. This addresses but does not close lightning#692.
|
I suggested the wording "MUST request |
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
That sounds reasonable, ACK.
|
ACK |
niftynei
added
the
clarification
|
As discussed during the spec meeting on Monday 2020/01/20 I rephrased the requirement for trailing |
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
Woops good catch, ACK afba7a7
|
Rebased and squashed ACK 29f1386 |
| - if a specific minimum `amount` is required for successful payment: | ||
| - MUST include that `amount`. | ||
| - MUST encode `amount` as a positive decimal integer with no leading 0s. | ||
| - If the `p` multiplier is used the `amount` the last decimal MUST be `0`. |
There was a problem hiding this comment.
nit: @cdecker I think you missed a last comment that this sentence is weird.
It should be: "If the p multiplier is used the last decimal of the amount MUST be 0."
There was a problem hiding this comment.
Oh damn, I thought there was a fixup from @Sword-Smith that fixed that. I'll open a new PR with the spelling mistake.
There was a problem hiding this comment.
I think I did leave a fixup. But for some reason it didn't get included. I made a new PR
#733
4 participants
When the
pmultiplier is used, the amount MUST be divisibleby 10 since the resolution used internally is millisatoshi.
This addresses but does not close- #692.