Bolt 11: add distinct HRP prefix for Bitcoin signet#844
Merged
Conversation
Judging from the comment https://github.com/bitcoin/bitcoin/pull/18267/files#r491150895 in the Signet PR all test networks should have the same bech32_hrp prefix (even regtest). That's why 'tb' was chosen for Signet as well. This is not optimal for LN as invoices shouldn't be vague in what network they were issued for. Therefore we add the explicit prefix 'lntbs' for Signet invoices.
23 tasks
Collaborator
|
That looks reasonable, I don't have a strong opinion on the naming, |
19 tasks
Collaborator
|
Merging as discussed during yesterday's spec meeting. |
guggero
added a commit
to guggero/lnd
that referenced
this pull request
May 18, 2021
The Core devs decided to us the same bech32 HRP for Signet as is used for the current Testnet3. This might be okay for on-chain addresses since they are compatible in theory. But for invoices we want to use a distinct HRP to distinguish testnet from signet. Also see spec PR lightning/bolts#844 for more information about the reasoning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Judging from the comment
https://github.com/bitcoin/bitcoin/pull/18267/files#r491150895 in the
Signet PR all test networks should have the same bech32_hrp prefix (even
regtest). That's why
tbwas chosen for Signet as well.This is not optimal for LN as invoices shouldn't be vague in
what network they were issued for.
Therefore we add the explicit prefix
lntbsfor Signet invoices.This PR was motivated by this comment: lightningnetwork/lnd#5025 (comment)
The actual value (
lntbs?lnbcsn?lnsn?) is open for discussion IMO.For reference, CL already wrote some code to handle the current issue of testnet and signet using the same prefix: https://github.com/ElementsProject/lightning/blob/030a19a8af989db38d3c547a81faff5b1e11608d/common/bolt11.c#L613