Deterministic points#862
Closed
rustyrussell wants to merge 2 commits into
Closed
Conversation
This commit adds the interactive transaction construction protcol, as well as the first practical example of using it, v2 of channel establishment. Note that for v2 we also update the channel_id, which now uses the hash of the revocation_basepoints. We move away from using the funding transaction id, as the introduction of RBF* makes it such that a single channel may have many funding transaction id's over the course of its lifetime. *Later, also splicing
Using a scheme derived from Lloyd Fournier's: https://lists.linuxfoundation.org/pipermail/lightning-dev/2020-December/002907.html Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
12 tasks
Collaborator
Author
|
After careful consideration, I am withdrawing this. The issue is that it is no longer possible to have separate secret keys for each channel: a compromise of one channel's keys would compromise the others. That isn't a security requirement right now, but it's definitely a valid security model: you can hold all your own channels' keys and contain the damage that can be done. c-lightning early on operated in this manner, for example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of @niftynei 's https://github.com/lightningnetwork/lightning-rfc/pull/851/commits, this alters that protocol to use @LLFourn's deterministic points.
This is useful, because splice wants to change the points, and now it's as easy as updating the generation.