s/send a warning/warn the user/ in BOLT 5 to avoid confusion#951
Merged
t-bast merged 1 commit intoJan 17, 2022
Merged
Conversation
freddiekrugerrand
approved these changes
Jan 6, 2022
freddiekrugerrand
left a comment
freddiekrugerrand
left a comment
There was a problem hiding this comment.
fwiw bolt 1 also references a warning in "Also, on several platforms it's possible that Lightning
clients will be put to sleep without prior warning", but that's more clearly distinguished from the warning message imo so probably doesn't need changing.
Nice clarification!
vincenzopalazzo
approved these changes
Jan 8, 2022
Contributor
vincenzopalazzo
left a comment
vincenzopalazzo
left a comment
There was a problem hiding this comment.
LGTM, ACK fbee1da
18 tasks
Prior to the addition of `warning` messages, BOLT 5 specified a few cases where users should be warned that funds may have been lost. However, it used the phrasing "send a warning" which can now be confused with `warning` messages. Nodes should not generally inform their counterparty that they have been robbed.
TheBlueMatt
force-pushed
the
2022-01-warning-msg-confusion
branch
from
fbee1da to
27e8d9d
Compare
Collaborator
Author
agreed, don't think its worth changing. |
Collaborator
|
ACK 27e8d9d |
t-bast
approved these changes
Jan 17, 2022
t-bast
added
the
clarification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to the addition of
warningmessages, BOLT 5 specified afew cases where users should be warned that funds may have been
lost. However, it used the phrasing "send a warning" which can now
be confused with
warningmessages. Nodes should not generallyinform their counterparty that they have been robbed.