Add reason to Event::PaymentFailed and Event::ChannelClosed
#260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2024-02-add-payment-failed-reason
branch
2 times, most recently
from
573e0dc to
311c500
Compare
tnull
changed the title
reason to Event::PaymentFailedreason to Event::PaymentFailed and Event::ChannelClosed
tnull
force-pushed
the
2024-02-add-payment-failed-reason
branch
from
3358062 to
c4b53d5
Compare
jkczyz
reviewed
Feb 22, 2024
tnull
force-pushed
the
2024-02-add-payment-failed-reason
branch
from
c4b53d5 to
1aab36a
Compare
Collaborator
Author
|
FWIW, flaky Python test should be unrelated. |
tnull
force-pushed
the
2024-02-add-payment-failed-reason
branch
2 times, most recently
from
6704dad to
f697dc7
Compare
.. which declutters our `lib.rs` imports a bit.
tnull
force-pushed
the
2024-02-add-payment-failed-reason
branch
from
f697dc7 to
a062cb2
Compare
Collaborator
Author
Squashed the fixup without further changes. |
jkczyz
approved these changes
Feb 22, 2024
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
Any thoughts on including the reason in PaymentStatus?
Collaborator
Author
Yeah, maybe we should, although I kind of like the simplicity of |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259.
Fixes #247.
To provide some more insight why a payment failed, we expose the
PaymentFailureReasonin our event. We also expose thereasoninChannelClosed.